New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errata_seen() #72

Merged
merged 1 commit into from Nov 2, 2015

Conversation

Projects
None yet
2 participants
@lejeunerenard
Contributor

lejeunerenard commented Aug 31, 2015

errata_seen() returns a hash reference of errata with the line
number as the key and the errors on that line as the value.

To support situations where neither STDERR nor the "POD ERRORS" section are used but pod errors still need to be processed ( logged, etc ), I decided to create the all_errata key on the parser instead of using the errata key. Currently the errata key stands for errata in the "POD ERRORS" section and not all errata seen. If errata_seen() used the errata key and the no_errata_section attribute was set to true, it would return no errors. So I created an all inclusive key.

To test the new method, I converted t/whine.t to use it and as a result, t/whine.t is slightly cleaner.

Solves #71

Brought to you by the CPAN PR challenge.

Add errata_seen()
errata_seen() returns a hash reference of errata logged with the line
number as a key and the errors as the value.

Solves #71

marcgreen added a commit that referenced this pull request Nov 2, 2015

@marcgreen marcgreen merged commit 3b814b7 into perl-pod:master Nov 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@marcgreen

This comment has been minimized.

Show comment
Hide comment
@marcgreen

marcgreen Nov 2, 2015

Contributor

Thanks for the PR, @lejeunerenard!

Contributor

marcgreen commented Nov 2, 2015

Thanks for the PR, @lejeunerenard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment