Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit "Make perlbug Unicode-aware." broke perlbug on Win32 #13612

Closed
p5pRT opened this issue Feb 18, 2014 · 14 comments

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Feb 18, 2014

Migrated from rt.perl.org#121277 (status was 'resolved')

Searchable as RT121277$

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 18, 2014

From @bulk88

Created by @bulk88

Commit "Make perlbug Unicode-aware."
092c3af broke perlbug on Win32.
Previously perlbug always produced /r/n Win32 newlined text files. After
that commit I get unix newlined reports. I now can't edit them (perlbug
is set by default to use notepad on Win32 since forever, I like it that
way). See attached screenshot. Reverting that commit using git, then
running perlbug.pl to rebuild perlbug (no ext), then running that
perlbug (no ext), fixes the problem for me. I recently upgraded my
system blead perl from around 5.19.4-ish to last sunday's blead so it is
getting reported now.

Perl Info

Flags:
    category=utilities
    severity=high

Site configuration information for perl 5.19.9:

Configured by Owner at Wed Feb 12 06:47:30 2014.

Summary of my perl5 (revision 5 version 19 subversion 9) configuration:
  Derived from: 633f0fd2ca244ca83cc99b3af3a7d3ac2931850b
  Platform:
    osname=MSWin32, osvers=5.1, archname=MSWin32-x86-multi-thread
    uname=''
    config_args='undef'
    hint=recommended, useposix=true, d_sigaction=undef
    useithreads=define, usemultiplicity=define
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cl', ccflags ='-nologo -GF -W3 -Od -MD -Zi -DDEBUGGING -DWIN32 
-D_CONSOLE -DNO_STRICT  -DPERL_TEXTMODE_SCRIPTS 
-DPERL_HASH_FUNC_ONE_AT_A_TIME -DPERL_IMPLICIT_CONTEXT 
-DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T',
    optimize='-Od -MD -Zi -DDEBUGGING',
    cppflags='-DWIN32'
    ccversion='13.10.6030', gccversion='', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=8
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='__int64', 
lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='link', ldflags ='-nologo -nodefaultlib -debug  
-libpath:"c:\perl519\lib\CORE"  -machine:x86'
    libpth="C:\Program Files\Microsoft Visual Studio .NET 2003\VC7\lib"
    libs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib  
netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib  version.lib 
odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
    perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib 
winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib 
oleaut32.lib  netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib  
version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
    libc=msvcrt.lib, so=dll, useshrplib=true, libperl=perl519.lib
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -debug  
-libpath:"c:\perl519\lib\CORE"  -machine:x86'

Locally applied patches:
    uncommitted-changes


@INC for perl 5.19.9:
    C:/perl519/site/lib
    C:/perl519/lib
    .


Environment for perl 5.19.9:
    HOME (unset)
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=C:\perl519\bin;C:\Program Files\Microsoft Visual Studio .NET 
2003\Common7\IDE;C:\Program Files\Microsoft Visual Studio .NET 
2003\VC7\BIN;C:\Program Files\Microsoft Visual Studio .NET 
2003\Common7\Tools;C:\Program Files\Microsoft Visual Studio .NET 
2003\Common7\Tools\bin\prerelease;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\system32\wbem;
    PERL_BADLANG (unset)
    SHELL (unset)


@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 18, 2014

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Mar 24, 2014

From @bulk88

This ticket got discussion in http​://www.nntp.perl.org/group/perl.perl5.porters/2014/03/msg213931.html

--
bulk88 ~ bulk88 at hotmail.com

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Mar 29, 2014

From @craigberry

On Mon, Mar 24, 2014 at 4​:52 PM, bulk88 via RT
<perlbug-followup@​perl.org> wrote​:

This ticket got discussion in http​://www.nntp.perl.org/group/perl.perl5.porters/2014/03/msg213931.html

I took a (blind) stab at trying to add the :crlf layer everywhere that
I thought perlbug was opening a file for output that might later be
opened by a user, or when perlbug was opening for input a file
previously created that way​:

http​://perl5.git.perl.org/perl.git/commitdiff/89405f1ff7acf59b59c9f5f21d2b7b539140f360

This is on the branch craigb/perlbug_encoding_fixup. It has not been
tested at all yet -- you could be the first :-).

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Mar 29, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Apr 1, 2014

From @bulk88

On Sat Mar 29 16​:09​:18 2014, craig.a.berry@​gmail.com wrote​:

On Mon, Mar 24, 2014 at 4​:52 PM, bulk88 via RT
<perlbug-followup@​perl.org> wrote​:

This ticket got discussion in
http​://www.nntp.perl.org/group/perl.perl5.porters/2014/03/msg213931.html

I took a (blind) stab at trying to add the :crlf layer everywhere that
I thought perlbug was opening a file for output that might later be
opened by a user, or when perlbug was opening for input a file
previously created that way​:

http​://perl5.git.perl.org/perl.git/commitdiff/89405f1ff7acf59b59c9f5f21d2b7b539140f360

This is on the branch craigb/perlbug_encoding_fixup. It has not been
tested at all yet -- you could be the first :-).

branch craigb/perlbug_encoding_fixup is fine, problem in notepad is now gone in that branch. I say feel free to merge.

--
bulk88 ~ bulk88 at hotmail.com

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Apr 4, 2014

From @bulk88

On Mon Mar 31 18​:29​:48 2014, bulk88 wrote​:

On Sat Mar 29 16​:09​:18 2014, craig.a.berry@​gmail.com wrote​:

This is on the branch craigb/perlbug_encoding_fixup. It has not been
tested at all yet -- you could be the first :-).

branch craigb/perlbug_encoding_fixup is fine, problem in notepad is
now gone in that branch. I say feel free to merge.

Bump. Its commit time.

--
bulk88 ~ bulk88 at hotmail.com

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Apr 4, 2014

From @craigberry

On Fri, Apr 4, 2014 at 1​:28 AM, bulk88 via RT <perlbug-followup@​perl.org> wrote​:

On Mon Mar 31 18​:29​:48 2014, bulk88 wrote​:

On Sat Mar 29 16​:09​:18 2014, craig.a.berry@​gmail.com wrote​:

This is on the branch craigb/perlbug_encoding_fixup. It has not been
tested at all yet -- you could be the first :-).

branch craigb/perlbug_encoding_fixup is fine, problem in notepad is
now gone in that branch. I say feel free to merge.

Bump. Its commit time.

Since we're in code freeze, it doesn't get committed without specific
say-so from the pumpking. Also, further discussion at

http​://www.nntp.perl.org/group/perl.perl5.porters/2014/04/msg214162.html

suggests a better path forward for encoding might be to assume UTF-8
for report text provided by the user unless the user specifies an
override. No one has commented on that nor have I gotten around to
implementing it. If we go that route it would touch all the same
places this branch touches to add the :crlf layer and it would be
cleaner to do all the layer handling in one shot.

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Apr 7, 2014

From @rjbs

On Fri Apr 04 07​:14​:11 2014, craig.a.berry@​gmail.com wrote​:

Since we're in code freeze, it doesn't get committed without specific
say-so from the pumpking. Also, further discussion at

http​://www.nntp.perl.org/group/perl.perl5.porters/2014/04/msg214162.html

suggests a better path forward for encoding […]

Please go ahead and apply.

If we get a better patch, that's great, too. Hopefully I can give this some time in the future myself. I think the "assume UTF-8 and provide a user override" is probably a good next step. Meantime, this much less broken is probably less broken enough.

--
rjbs

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Apr 11, 2014

From @craigberry

On Mon, Apr 7, 2014 at 9​:24 AM, Ricardo SIGNES via RT
<perlbug-followup@​perl.org> wrote​:

On Fri Apr 04 07​:14​:11 2014, craig.a.berry@​gmail.com wrote​:

Since we're in code freeze, it doesn't get committed without specific
say-so from the pumpking. Also, further discussion at

http​://www.nntp.perl.org/group/perl.perl5.porters/2014/04/msg214162.html

suggests a better path forward for encoding [...]

Please go ahead and apply.

After some more testing, it's now in blead.

If we get a better patch, that's great, too. Hopefully I can give this some time in the future myself. I think the "assume UTF-8 and provide a user override" is probably a good next step. Meantime, this much less broken is probably less broken enough.

I've started to look at implementing the UTF-8 default with override
option and will put it in a branch for perusal. Not necessarily in
time for 5.20 but we'll see.

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Apr 14, 2014

From @rjbs

As the critical breakage is gone, I've removed this from the blockers list.

--
rjbs

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 26, 2016

From @mauke

On Mon Apr 14 07​:03​:17 2014, rjbs wrote​:

As the critical breakage is gone, I've removed this from the blockers list.

The original problem reported in this ticket is fixed. Is there still activity that needs to happen here or can we close this ticket?

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 26, 2016

From @bulk88

On Fri Feb 26 09​:13​:23 2016, mauke- wrote​:

On Mon Apr 14 07​:03​:17 2014, rjbs wrote​:

As the critical breakage is gone, I've removed this from the blockers
list.

The original problem reported in this ticket is fixed. Is there still
activity that needs to happen here or can we close this ticket?

Close it, the bug was fixed, perlbug+notepad work uneventfully for me.

--
bulk88 ~ bulk88 at hotmail.com

@p5pRT p5pRT closed this Feb 26, 2016
@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 26, 2016

@mauke - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.