Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attribute on lexical introduced in hash constructor #14500

Closed
p5pRT opened this issue Feb 13, 2015 · 6 comments
Labels

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Feb 13, 2015

Migrated from rt.perl.org#123817 (status was 'resolved')

Searchable as RT123817$

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 13, 2015

From @hvds

AFL (<http​://lcamtuf.coredump.cx/afl>) finds this​:

% ./perl -e '$y = { my $x : m }'
Invalid SCALAR attribute​: m at -e line 1.
perl​: op.c​:721​: Perl_op_free​: Assertion `!(o->op_private & ~PL_op_private_valid[type])' failed.
Aborted (core dumped)
%

This is OPpLVAL_INTRO set on the initial OP_LIST by my_attrs, preserved when it's converted by newANONHASH.

I suspect at least newANONLIST() and newANONHASH() should simply clear that flag, but I'm not sure what if any impact that might have, and not sure if any of the other op_convert_list() callers should.

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Mar 1, 2015

From @cpansprout

On Fri Feb 13 06​:28​:39 2015, hv wrote​:

AFL (<http​://lcamtuf.coredump.cx/afl>) finds this​:

% ./perl -e '$y = { my $x : m }'
Invalid SCALAR attribute​: m at -e line 1.
perl​: op.c​:721​: Perl_op_free​: Assertion `!(o->op_private &
~PL_op_private_valid[type])' failed.
Aborted (core dumped)
%

This is OPpLVAL_INTRO set on the initial OP_LIST by my_attrs,
preserved when it's converted by newANONHASH.

I suspect at least newANONLIST() and newANONHASH() should simply clear
that flag, but I'm not sure what if any impact that might have, and
not sure if any of the other op_convert_list() callers should.

I fixed this in 6b2b48a by turning off the flag in op_convert_list.

--

Father Chrysostomos

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Mar 1, 2015

The RT System itself - Status changed from 'new' to 'open'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Mar 1, 2015

@cpansprout - Status changed from 'open' to 'pending release'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Jun 2, 2015

From @khwilliamson

Thank you for submitting this ticket.

The issue should now be resolved with the release today of Perl v5.22, which is available at http​://www.perl.org/get.html
--
Karl Williamson for the Perl 5 team

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Jun 2, 2015

@khwilliamson - Status changed from 'pending release' to 'resolved'

@p5pRT p5pRT closed this Jun 2, 2015
@p5pRT p5pRT added the Severity Low label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.