Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corelist: wrong Digest::SHA version in 5.18.4? #15202

Closed
p5pRT opened this issue Feb 27, 2016 · 5 comments

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Feb 27, 2016

Migrated from rt.perl.org#127624 (status was 'resolved')

Searchable as RT127624$

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 27, 2016

From @mauke

Created by @mauke

$ corelist -v 5.18.4 Digest​::SHA
Digest​::SHA 5.84_01

But
https://metacpan.org/source/RJBS/perl-5.18.4/cpan/Digest-SHA/lib/Digest/SHA.pm
says​:

$VERSION = '5.84_02';

Perl Info

Flags:
    category=library
    severity=low
    module=Module::CoreList

Site configuration information for perl 5.22.1:

Configured by mauke at Tue Dec 29 15:36:05 CET 2015.

Summary of my perl5 (revision 5 version 22 subversion 1) configuration:
   
  Platform:
    osname=linux, osvers=4.2.5-1-arch, archname=i686-linux
    uname='linux simplicio 4.2.5-1-arch #1 smp preempt tue oct 27 08:28:41 cet 2015 i686 gnulinux '
    config_args=''
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2',
    cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion='', gccversion='5.3.0', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234, doublekind=3
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12, longdblkind=3
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/gcc/i686-pc-linux-gnu/5.3.0/include-fixed /usr/lib /lib
    libs=-lpthread -lnsl -lnm -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
    perllibs=-lpthread -lnsl -lnm -ldl -lm -lcrypt -lutil -lc
    libc=libc-2.22.so, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version='2.22'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'



@INC for perl 5.22.1:
    /home/mauke/usr/lib/perl5/site_perl/5.22.1/i686-linux
    /home/mauke/usr/lib/perl5/site_perl/5.22.1
    /home/mauke/usr/lib/perl5/5.22.1/i686-linux
    /home/mauke/usr/lib/perl5/5.22.1
    .


Environment for perl 5.22.1:
    HOME=/home/mauke
    LANG=en_US.UTF-8
    LANGUAGE=en_US
    LC_COLLATE=C
    LC_MONETARY=de_DE.UTF-8
    LC_TIME=de_DE.UTF-8
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/mauke/perl5/perlbrew/bin:/home/mauke/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl
    PERLBREW_BASHRC_VERSION=0.73
    PERLBREW_HOME=/home/mauke/.perlbrew
    PERLBREW_ROOT=/home/mauke/perl5/perlbrew
    PERL_BADLANG (unset)
    PERL_UNICODE=SAL
    SHELL=/bin/bash

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Mar 1, 2016

From @jkeenan

On Sat Feb 27 06​:22​:44 2016, mauke- wrote​:

This is a bug report for perl from l.mai@​web.de,
generated with the help of perlbug 1.40 running under perl 5.22.1.

-----------------------------------------------------------------
[Please describe your issue here]

$ corelist -v 5.18.4 Digest​::SHA
Digest​::SHA 5.84_01

But
https://metacpan.org/source/RJBS/perl-5.18.4/cpan/Digest-
SHA/lib/Digest/SHA.pm
says​:

$VERSION = '5.84_02';

Observation confirmed.

Locally I have available 5.18.2 and 5.18.4. IIRC, there was a considerable lapse of time between 5.18.2 and 5.18.3, but an error in 5.18.3 led to the quick issuance of 5.18.4.

The version of Module​::CoreList shipped with 5.18.2 is 3.03. This version correctly has a delta for Digest​::SHA in 5.18.1​:

#####
  5.018001 => {
  delta_from => 5.018000,
  changed => {
  'B' => '1.42_01',
  'Config' => '5.018001',
  'Digest​::SHA' => '5.84_01',
  'Module​::CoreList' => '2.96',
  'Module​::CoreList​::TieHashDelta'=> '2.96',
  'Module​::CoreList​::Utils'=> '2.96',
  },
  removed => {
  'VMS​::Filespec' => 1,
  }
  },
#####

The version of Module​::CoreList shipped with 5.18.4 was 3.13. This version lacks any delta for Digest​::SHA for either 5.18.3 or 5.18.4​:

#####
  5.018003 => {
  delta_from => 5.018002,
  changed => {
  'Module​::CoreList' => '3.12',
  'Module​::CoreList​::TieHashDelta'=> '3.12',
  'Module​::CoreList​::Utils'=> '3.12',
  },
  },
  5.018004 => {
  delta_from => 5.018003,
  changed => {
  'Module​::CoreList' => '3.13',
  'Module​::CoreList​::TieHashDelta'=> '3.13',
  'Module​::CoreList​::Utils'=> '3.13',
  },
  },
#####

This appears to explain why 'corelist -v 5.18.4 Digest​::SHA' fails to detect Digest​::SHA version 5.84_02.

Whether we can or should try to fix this at this late date should be discussed.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Mar 1, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Nov 14, 2017

From zefram@fysh.org

This was fixed in commit b564105,
in perl 5.23.9.

-zefram

@p5pRT p5pRT closed this Nov 14, 2017
@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Nov 14, 2017

@cpansprout - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.