Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Fix copy/paste error in Configure #15423

Closed
p5pRT opened this issue Jul 4, 2016 · 8 comments

Comments

@p5pRT
Copy link

commented Jul 4, 2016

Migrated from rt.perl.org#128538 (status was 'resolved')

Searchable as RT128538$

@p5pRT

This comment has been minimized.

Copy link
Author

commented Jul 4, 2016

From @dcollinsn

Self-explanatory. The code in question adds -quadmath to archname, but only if it isn't already there. However, since this was copied from a few lines earlier, it checks for -ld instead of -quadmath.

@p5pRT

This comment has been minimized.

Copy link
Author

commented Jul 4, 2016

From @dcollinsn

0001-Configure-fix-copy-paste-error-in-archname.patch
From 770fefe24cb2e491ab8686431a70729231f14dab Mon Sep 17 00:00:00 2001
From: Dan Collins <dcollinsn@gmail.com>
Date: Mon, 4 Jul 2016 16:20:57 -0400
Subject: [PATCH] Configure: fix copy-paste error in archname

---
 Configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Configure b/Configure
index 42c67f3..68730f5 100755
--- a/Configure
+++ b/Configure
@@ -7187,8 +7187,8 @@ case "$usequadmath" in
 $define)
 	echo "quadmath selected." >&4
 	case "$archname" in
-	*-ld*) echo "...and architecture name already has -quadmath." >&4
-		;;
+	*-quadmath*) echo "...and architecture name already has -quadmath." >&4
+		     ;;
 	*)      archname="$archname-quadmath"
 		echo "...setting architecture name to $archname." >&4
 		;;
-- 
2.8.1

@p5pRT

This comment has been minimized.

Copy link
Author

commented Jul 5, 2016

From @Tux

On Mon, 4 Jul 2016 16​:14​:28 -0700, Dan Collins (via RT)
<perlbug-followup@​perl.org> wrote​:

Self-explanatory. The code in question adds -quadmath to archname,
but only if it isn't already there. However, since this was copied
from a few lines earlier, it checks for -ld instead of -quadmath.

Well spotted! Thanks, applied commit d06c8f8
Also applied in meta as adc7640845fa03ace8d13edd92d8b2a3685690b2

--
H.Merijn Brand http​://tux.nl Perl Monger http​://amsterdam.pm.org/
using perl5.00307 .. 5.23 porting perl5 on HP-UX, AIX, and openSUSE
http​://mirrors.develooper.com/hpux/ http​://www.test-smoke.org/
http​://qa.perl.org http​://www.goldmark.org/jeff/stupid-disclaimers/

@p5pRT

This comment has been minimized.

Copy link
Author

commented Jul 5, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT

This comment has been minimized.

Copy link
Author

commented Jul 6, 2016

From @tonycoz

On Tue Jul 05 09​:52​:13 2016, hmbrand wrote​:

Well spotted! Thanks, applied commit
d06c8f8
Also applied in meta as adc7640845fa03ace8d13edd92d8b2a3685690b2

Marking done.

Tony

@p5pRT

This comment has been minimized.

Copy link
Author

commented Jul 6, 2016

@tonycoz - Status changed from 'open' to 'pending release'

@p5pRT

This comment has been minimized.

Copy link
Author

commented May 30, 2017

From @khwilliamson

Thank you for filing this report. You have helped make Perl better.

With the release today of Perl 5.26.0, this and 210 other issues have been
resolved.

Perl 5.26.0 may be downloaded via​:
https://metacpan.org/release/XSAWYERX/perl-5.26.0

If you find that the problem persists, feel free to reopen this ticket.

@p5pRT

This comment has been minimized.

Copy link
Author

commented May 30, 2017

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.