Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing av_top_index in Devel::PPPort #16586

Closed
p5pRT opened this issue Jun 13, 2018 · 9 comments
Labels

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Jun 13, 2018

Migrated from rt.perl.org#133278 (status was 'resolved')

Searchable as RT133278$

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Jun 13, 2018

From rehsack@gmail.com

perlapi reports AvFILL is deprecated and encourages using of av_top_index() instead.
Unfortunately av_top_index has been introduced with 5.18 - ideally ppport.h supports a fallback for older Perls.

See https://travis-ci.org/perl5-utils/List-MoreUtils-XS/builds/391774513 for the failures (with up-to-date ppport.h)
The 5.18 failure comes from unfortunate recover from RT#123868/RT#96343 (cpan) and needs rework from author (me).

Best regards
--
Jens Rehsack - rehsack@​gmail.com

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Jun 15, 2018

From @khwilliamson

On Wed, 13 Jun 2018 09​:19​:39 -0700, rehsack@​gmail.com wrote​:

perlapi reports AvFILL is deprecated and encourages using of
av_top_index() instead.
Unfortunately av_top_index has been introduced with 5.18 - ideally
ppport.h supports a fallback for older Perls.

I agree, and will work on it shortly

See https://travis-ci.org/perl5-utils/List-MoreUtils-
XS/builds/391774513 for the failures (with up-to-date ppport.h)
The 5.18 failure comes from unfortunate recover from
RT#123868/RT#96343 (cpan) and needs rework from author (me).

Best regards
--
Jens Rehsack - rehsack@​gmail.com

--
Karl Williamson

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Jun 15, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Jun 15, 2018

From @tonycoz

On Wed, Jun 13, 2018 at 09​:19​:39AM -0700, Jens Rehsack (via RT) wrote​:

# New Ticket Created by Jens Rehsack
# Please include the string​: [perl #133278]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133278 >

perlapi reports AvFILL is deprecated and encourages using of av_top_index() instead.
Unfortunately av_top_index has been introduced with 5.18 - ideally ppport.h supports a fallback for older Perls.

See https://travis-ci.org/perl5-utils/List-MoreUtils-XS/builds/391774513 for the failures (with up-to-date ppport.h)
The 5.18 failure comes from unfortunate recover from RT#123868/RT#96343 (cpan) and needs rework from author (me).

AvFILL() shouldn't deprecated, maybe discouraged, but not deprecated.

Tony

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Jul 17, 2018

From @khwilliamson

On Thu, 14 Jun 2018 23​:02​:25 -0700, tonyc wrote​:

On Wed, Jun 13, 2018 at 09​:19​:39AM -0700, Jens Rehsack (via RT) wrote​:

# New Ticket Created by Jens Rehsack
# Please include the string​: [perl #133278]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133278 >

perlapi reports AvFILL is deprecated and encourages using of
av_top_index() instead.
Unfortunately av_top_index has been introduced with 5.18 - ideally
ppport.h supports a fallback for older Perls.

See https://travis-ci.org/perl5-utils/List-MoreUtils-
XS/builds/391774513 for the failures (with up-to-date ppport.h)
The 5.18 failure comes from unfortunate recover from
RT#123868/RT#96343 (cpan) and needs rework from author (me).

AvFILL() shouldn't deprecated, maybe discouraged, but not deprecated.

Tony

I changed perlapi to not say that this was deprecated (it isn't) in commit
d29fa84

Still working on Devel​::PPPort
--
Karl Williamson

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Apr 27, 2019

From @khwilliamson

This is now fixed in blead, and available for download from cpan
--
Karl Williamson

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Apr 27, 2019

@khwilliamson - Status changed from 'open' to 'pending release'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented May 22, 2019

From @khwilliamson

Thank you for filing this report. You have helped make Perl better.

With the release today of Perl 5.30.0, this and 160 other issues have been
resolved.

Perl 5.30.0 may be downloaded via​:
https://metacpan.org/release/XSAWYERX/perl-5.30.0

If you find that the problem persists, feel free to reopen this ticket.

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented May 22, 2019

@khwilliamson - Status changed from 'pending release' to 'resolved'

@p5pRT p5pRT closed this May 22, 2019
@p5pRT p5pRT added the Severity Low label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.