Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Fix B extension skip in ext/B/t/strict.t #16783

Closed
p5pRT opened this issue Dec 7, 2018 · 6 comments
Labels

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Dec 7, 2018

Migrated from rt.perl.org#133713 (status was 'resolved')

Searchable as RT133713$

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Dec 7, 2018

From @ppisar

If perl is built in an environment with a locale where
"B" > "attribute" (e.g. "C" locale), ext/B/t/strict.t test will be skipped
in contrast to other B tests​:

../ext/B/t/showlex.t .............. ok
../ext/B/t/strict.t ............... skipped​: Perl was not compiled with B

The tests match $Config{'extensions'} for "B" and skip the tests if not
found. However, ext/B/t/strict.t uses a distinct regular expression
that fails if $Config{'extensions'} starts with "B ".

This patch makes the ext/B/t/strict.t test alike to other ones.

Signed-off-by​: Petr PísaÅ� <ppisar@​redhat.com>


ext/B/t/strict.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Inline Patch
diff --git a/ext/B/t/strict.t b/ext/B/t/strict.t
index 4d1b84aa20..9f5eacd7da 100644
--- a/ext/B/t/strict.t
+++ b/ext/B/t/strict.t
@@ -7,7 +7,7 @@ use Config;
 use Test::More;
 
 BEGIN {
-    if ( ( $Config{'extensions'} !~ /\sB\s/ ) ) {
+    if ( ( $Config{'extensions'} !~ /\bB\b/ ) ) {
         plan skip_all => "Perl was not compiled with B";
         exit 0;
     }
-- 
2.17.2
@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Dec 7, 2018

From @jkeenan

On Fri, 07 Dec 2018 11​:30​:44 GMT, ppisar wrote​:

If perl is built in an environment with a locale where
"B" > "attribute" (e.g. "C" locale), ext/B/t/strict.t test will be skipped
in contrast to other B tests​:

../ext/B/t/showlex.t .............. ok
../ext/B/t/strict.t ............... skipped​: Perl was not compiled with B

The tests match $Config{'extensions'} for "B" and skip the tests if not
found. However, ext/B/t/strict.t uses a distinct regular expression
that fails if $Config{'extensions'} starts with "B ".

This patch makes the ext/B/t/strict.t test alike to other ones.

Signed-off-by​: Petr PísaÅ� <ppisar@​redhat.com>
---
ext/B/t/strict.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ext/B/t/strict.t b/ext/B/t/strict.t
index 4d1b84aa20..9f5eacd7da 100644
--- a/ext/B/t/strict.t
+++ b/ext/B/t/strict.t
@​@​ -7,7 +7,7 @​@​ use Config;
use Test​::More;

BEGIN {
- if ( ( $Config{'extensions'} !~ /\sB\s/ ) ) {
+ if ( ( $Config{'extensions'} !~ /\bB\b/ ) ) {
plan skip_all => "Perl was not compiled with B";
exit 0;
}

Thanks. Pushed to blead in commit dc0a6b7

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Dec 7, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Dec 7, 2018

@jkeenan - Status changed from 'open' to 'pending release'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented May 22, 2019

From @khwilliamson

Thank you for filing this report. You have helped make Perl better.

With the release today of Perl 5.30.0, this and 160 other issues have been
resolved.

Perl 5.30.0 may be downloaded via​:
https://metacpan.org/release/XSAWYERX/perl-5.30.0

If you find that the problem persists, feel free to reopen this ticket.

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented May 22, 2019

@khwilliamson - Status changed from 'pending release' to 'resolved'

@p5pRT p5pRT closed this May 22, 2019
@p5pRT p5pRT added the Severity Low label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.