inline subs #23

Open
rurban opened this Issue Sep 11, 2015 · 0 comments

Projects

None yet

1 participant

@rurban
Member
rurban commented Sep 11, 2015

perl-5.003_02 added an incomplete op_const_sv to check an optree for a single const or pad, and to mark it as CvCONST then. 760ac83
Nothing much changed since then.

This is

  1. wrong. only const pad values may be used like this. sideeffects changing the lexical are not safe. 5.22 started warning about this condition.
  2. not enough. proper constant folding should be done to check if the body may be inlinable.

Splice a OP* into the caller if inlinable, not just a CONSTSUB via the const_sv logic.
With some heuristic/cost calculation when it makes sense.

we can also use the new :const and :pure attributes to mark functions as inlinable.
:const to bypass the constant folding check, :pure to mark the closed over lexicals as not being changed by sideeffects.

Note: inlined subs and methods are a huge performance win in most dynamic languages. esp. with the slow perl function calls, it might be a big win.

Analyze the body and check if a enter/leave is needed, and if the args can be hardcoded into the inlined body (optim_args). this can be done by ref (with consts and with $_[]) or by value via copies of the sv/pad.
otherwise use a simple push @_ , args oplist instead of the pushmark args gv entersub sequence.

The inlined body needs to be copied, as the nextstate and args needs to be changed. We can do this on the fly, or 2nd or more generally add a new op_clone_oplist() API, which just clones the ops, not the data.

See the branch feature/CM-707-cperl-inline-subs

@rurban rurban self-assigned this Sep 11, 2015
@rurban rurban added the enhancement label Sep 11, 2015
@rurban rurban added this to the v5.24.0 milestone Sep 13, 2015
@rurban rurban modified the milestone: v5.24.1, v5.24.0 May 10, 2016
@rurban rurban modified the milestone: v5.26.0, v5.24.1 Oct 11, 2016
@rurban rurban added the in progress label Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment