New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose role methods #311

Open
rurban opened this Issue Jul 20, 2017 · 1 comment

Comments

1 participant
@rurban
Member

rurban commented Jul 20, 2017

when copying methods from roles, the pad's might be different.
if so adjust them, if not a GV alias should be enough.

@rurban rurban added this to the v5.27.1c milestone Jul 20, 2017

@rurban rurban added ready in progress and removed ready labels Jul 21, 2017

rurban added a commit that referenced this issue Jul 21, 2017

role: work on add_does_methods
parse composed fields.
avoid wrong fields check, as we already copied the field.
See #311

rurban added a commit that referenced this issue Jul 21, 2017

role: work on add_does_methods
parse composed fields.
avoid wrong fields check, as we already copied the field.
See #311

rurban added a commit that referenced this issue Jul 21, 2017

role: work on add_does_methods
parse composed fields.
avoid wrong fields check, as we already copied the field.
See #311

@rurban rurban self-assigned this Jul 21, 2017

@rurban rurban modified the milestones: v5.27.2c, v5.27.1c Aug 14, 2017

@rurban

This comment has been minimized.

Show comment
Hide comment
@rurban

rurban Aug 22, 2017

Member

I assume this was fixed with #309 10fcc61
No, it was not.
With changed field indices oelemfast needs to be fixed up, which means the GV alias is wrong.
But then we need a fresh new optree, op_clone, which only exists in the inliner yet.
So we might need to undo the OELEMFAST optim, or merge parts of the inliner already.

Since 858469b we panic in those case. Needs to be fixed.

Member

rurban commented Aug 22, 2017

I assume this was fixed with #309 10fcc61
No, it was not.
With changed field indices oelemfast needs to be fixed up, which means the GV alias is wrong.
But then we need a fresh new optree, op_clone, which only exists in the inliner yet.
So we might need to undo the OELEMFAST optim, or merge parts of the inliner already.

Since 858469b we panic in those case. Needs to be fixed.

rurban added a commit that referenced this issue Aug 23, 2017

fields: add test-case for mixed-up indices
when composing roles. GH #311
also fix remaining field_search last param.

rurban added a commit that referenced this issue Aug 23, 2017

fields: WIP add role method fixup
we cannot always alias methods. when roles are composed
out of order, the file indices do not match up.
since we guarantee natural field order, esp. for :native
we need to adjust the field indices in copied methods, GH #311

note that ruby or potion do reorder composed fields, to avoid
these fixups.

rurban added a commit that referenced this issue Aug 23, 2017

fields: panic on #311
until it is fixed

rurban added a commit that referenced this issue Aug 23, 2017

fields: panic on #311
until it is fixed

@rurban rurban modified the milestones: v5.27.2c, v5.27.3c Dec 5, 2017

@rurban rurban added this to In progress in cperl Dec 16, 2017

@rurban rurban added ready and removed in progress labels Apr 10, 2018

@rurban rurban removed the blocking label Sep 3, 2018

@rurban rurban modified the milestones: v5.27.3c, v5.29.1c Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment