Fix "assignment from incompatible pointer type" #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I encountered this warning from gcc 7.3.0 building on Ubuntu:
dbdimp.c: In function ‘mysql_st_prepare’:
dbdimp.c:3207:24: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
bind->is_null= (_Bool*) &(fbind->is_null);
The "MYSQL_BIND" field "is_null" is of type "my_bool", not "_Bool".
The type "my_bool" is (usually) type-defined to be of a "char" type.
Regardless, the "imp_sth_phb_t" field "is_null" is of type "char".
This commit removes the cast, which means that if we later discover
that "my_bool" is defined to be of a type incompatible with the
"imp_sth_phb_t" field "is_null", it will break at compile-time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this warning from gcc 7.3.0 building on Ubuntu:
dbdimp.c: In function ‘mysql_st_prepare’:dbdimp.c:3207:24: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]bind->is_null= (_Bool*) &(fbind->is_null);The
MYSQL_BINDfieldis_nullis of typemy_bool, not_Bool.The type
my_boolis (usually) type-defined to be of achartype.Regardless, the
imp_sth_phb_tfieldis_nullis of typechar.This commit removes the cast, which means that if we later discover that
my_boolis defined to be of a type incompatible with theimp_sth_phb_tfieldis_null, it will break at compile-time.