New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a license file #21

Merged
merged 1 commit into from May 26, 2015

Conversation

Projects
None yet
4 participants
@jluis
Contributor

jluis commented May 26, 2015

This is part of my Mai CPAN pull request
The LICENSE file contains some relevant paragrafs from perl 5.008 README an the text of licenses

timbunce added a commit that referenced this pull request May 26, 2015

@timbunce timbunce merged commit f0f6003 into perl5-dbi:master May 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jluis jluis deleted the jluis:cpanprjluis branch May 28, 2015

@ribasushi

This comment has been minimized.

Show comment
Hide comment
@ribasushi

ribasushi Jul 14, 2015

Member

@jluis Sorry for the belated review: there is a glaring problem with this PR: the copyright is misattributed to a completely different person

Additionally consider further specifying the "as perl itself" verbiage, as seen here

Thank you for the contributions!

/cc @timbunce

Member

ribasushi commented Jul 14, 2015

@jluis Sorry for the belated review: there is a glaring problem with this PR: the copyright is misattributed to a completely different person

Additionally consider further specifying the "as perl itself" verbiage, as seen here

Thank you for the contributions!

/cc @timbunce

jluis added a commit to jluis/dbi that referenced this pull request Jul 14, 2015

timbunce added a commit that referenced this pull request Jul 18, 2015

@pghmcfc

This comment has been minimized.

Show comment
Hide comment
@pghmcfc

pghmcfc Aug 3, 2015

I think the tooling also needs updating so that the LICENSE file actually gets shipped in the built dist.

pghmcfc commented Aug 3, 2015

I think the tooling also needs updating so that the LICENSE file actually gets shipped in the built dist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment