New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strictures on all lib/ files #22

Merged
merged 1 commit into from May 26, 2015

Conversation

Projects
None yet
4 participants
@jluis
Contributor

jluis commented May 26, 2015

This is part of my May CPAN pull request
Adds "use strict" earlier on the files where it was missing.
predeclares the variables with our (..,); on most of the packages
some of the pakages declare wiht our on the creation of the variable;

I did not change the variables declared with vars pragma

Enable strictures on all lib/ files
looks like some of the packages didn't "use strict" because Perl 5.005_03
but minimum version is 5.008 now

Signed-off-by: Jose Luis Perez Diez <jluis@escomposlinux.org>

timbunce added a commit that referenced this pull request May 26, 2015

Merge pull request #22 from jluis/cpanprjluis2
Enable strictures on all lib/ files

@timbunce timbunce merged commit e4e0a38 into perl5-dbi:master May 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ribasushi

This comment has been minimized.

Show comment
Hide comment
@ribasushi

ribasushi Jul 14, 2015

Member

@timbunce Please consider doing a dev release and smoking it for couple weeks at least. While these changes may look innocuous, there may be dragons inside.

Member

ribasushi commented Jul 14, 2015

@timbunce Please consider doing a dev release and smoking it for couple weeks at least. While these changes may look innocuous, there may be dragons inside.

@garu

This comment has been minimized.

Show comment
Hide comment
@garu

garu Jul 20, 2015

@jluis++ for this PR;
@timbunce++ for merging;
@ribasushi++ for advising a dev release (call me cautious but I'm hoping for more than just a couple weeks, and I'd monitor FAILs from as many downstream dists as possible). Meanwhile I'll upgrade my company's dev environment to this version and let you know if anything breaks!

Thanks again for all the great work put into DBI!

garu commented Jul 20, 2015

@jluis++ for this PR;
@timbunce++ for merging;
@ribasushi++ for advising a dev release (call me cautious but I'm hoping for more than just a couple weeks, and I'd monitor FAILs from as many downstream dists as possible). Meanwhile I'll upgrade my company's dev environment to this version and let you know if anything breaks!

Thanks again for all the great work put into DBI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment