Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always display google search option #1391

Closed
zoffixznet opened this issue Jun 21, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@zoffixznet
Copy link
Contributor

commented Jun 21, 2017

If you type a search term and no results show up, you're given an option to do a google search for that term. However, that option isn't available when some results turned up.

I think the option to do a google search should always be present because the found results might not be what the user is looking for (e.g. I searched for "binder"), yet the site might still have the word used somewhere the search index didn't grab it, so a google search would still be useful.

@JJ

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2018

I have been testing with this. It looks easy in principle, just a matter of commenting out the part of the JS in search.js that adds this only if there are no results. However, there are some minor and some major problems. Minor one is the message, which is "Not found". That can be changed. Major one is that the message is not "added", but rather pops up in a separate div when the drop-down menu is closed. That's not noticed with no result because there's no result.
So, for a quick-and-dirty solution, if not ideal in UX terms, it can be done fast addressing this issue (it displays google search option alright). However, I wonder if you were thinking more along the lines of adding it as the last option in the dropdown menu or something like that...

@AlexDaniel

This comment has been minimized.

Copy link
Member

commented Mar 16, 2018

However, I wonder if you were thinking more along the lines of adding it as the last option in the dropdown menu or something like that...

Yes.

@JJ

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2018

@randyl

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2018

Closed by #2171

@randyl randyl closed this Jul 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.