Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the interrobang in unrelated Sub traits example ‽ #2163

Closed
pmurias opened this issue Jul 9, 2018 · 4 comments
Closed

Stop using the interrobang in unrelated Sub traits example ‽ #2163

pmurias opened this issue Jul 9, 2018 · 4 comments

Comments

@pmurias
Copy link
Contributor

pmurias commented Jul 9, 2018

The problem

Interrobang is an rare character that does display in some fonts and looks like a potentially syntactic element

Suggestions

Replace the example.
Using something better than an nonsense world oi is also better.

@JJ
Copy link
Contributor

JJ commented Jul 9, 2018

But it's in a string... I don't see a big problem with using it, or for that matter for changing it to something else.

@JJ JJ closed this as completed in 93af3ea Jul 9, 2018
@AlexDaniel
Copy link
Member

@pmurias are you satisfied with the commit above? Or did you mean something else?

@AlexDaniel AlexDaniel reopened this Jul 9, 2018
@JJ
Copy link
Contributor

JJ commented Jul 9, 2018 via email

@pmurias
Copy link
Contributor Author

pmurias commented Jul 9, 2018

@AlexDaniel The commits solves the issue ;)

@pmurias pmurias closed this as completed Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants