New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Telemetry and Telemetry::Period, lizmat++ #1660

Merged
merged 10 commits into from Nov 6, 2017

Conversation

Projects
None yet
3 participants
@TisonKun
Contributor

TisonKun commented Nov 5, 2017

These pod6 files cause build failure, maybe we can rewrite it in correct format.

@AlexDaniel

This comment has been minimized.

Show comment
Hide comment
@AlexDaniel

AlexDaniel Nov 5, 2017

Member

Can we also add a note saying that this is a Rakudo feature that is available starting with 2017.11 release?

Member

AlexDaniel commented Nov 5, 2017

Can we also add a note saying that this is a Rakudo feature that is available starting with 2017.11 release?

@TisonKun

This comment has been minimized.

Show comment
Hide comment
@TisonKun

TisonKun Nov 5, 2017

Contributor

@AlexDaniel is it a rakudo only feature?

Contributor

TisonKun commented Nov 5, 2017

@AlexDaniel is it a rakudo only feature?

@AlexDaniel

This comment has been minimized.

Show comment
Hide comment
@AlexDaniel

AlexDaniel Nov 5, 2017

Member

@W4anD0eR96 Until we have tests for it in roast it is fair to assume that new potential implementations will not implement it. Another similar case is dd.

Member

AlexDaniel commented Nov 5, 2017

@W4anD0eR96 Until we have tests for it in roast it is fair to assume that new potential implementations will not implement it. Another similar case is dd.

@lizmat

This comment has been minimized.

Show comment
Hide comment
@lizmat

lizmat Nov 5, 2017

Member

Yes, no tests in roast, just like dd. I would not consider it a Perl 6 feature at this time.

Member

lizmat commented Nov 5, 2017

Yes, no tests in roast, just like dd. I would not consider it a Perl 6 feature at this time.

@lizmat

This comment has been minimized.

Show comment
Hide comment
@lizmat

lizmat Nov 5, 2017

Member

eh, where did doc/Type/Telemetry.pod6 go ??? It's not in the branch ?

Member

lizmat commented Nov 5, 2017

eh, where did doc/Type/Telemetry.pod6 go ??? It's not in the branch ?

@TisonKun

This comment has been minimized.

Show comment
Hide comment
@TisonKun

TisonKun Nov 5, 2017

Contributor

@lizmat , it's in this branch, both of them cause build failure. try to figure it out now.

Contributor

TisonKun commented Nov 5, 2017

@lizmat , it's in this branch, both of them cause build failure. try to figure it out now.

@lizmat

This comment has been minimized.

Show comment
Hide comment
@lizmat

lizmat Nov 5, 2017

Member

odd, in my local checkout it's definitely not there if I checkout the branch

Member

lizmat commented Nov 5, 2017

odd, in my local checkout it's definitely not there if I checkout the branch

@TisonKun

This comment has been minimized.

Show comment
Hide comment
@TisonKun

TisonKun Nov 5, 2017

Contributor

it's in branch patch-01

Contributor

TisonKun commented Nov 5, 2017

it's in branch patch-01

@lizmat

This comment has been minimized.

Show comment
Hide comment
@lizmat

lizmat Nov 5, 2017

Member

Ok, I'll leave you to it then :-)

Member

lizmat commented Nov 5, 2017

Ok, I'll leave you to it then :-)

TisonKun added some commits Nov 5, 2017

@TisonKun TisonKun changed the title from Document Telemetry and Telemetry::Period, lizmat++ to [WIP] Document Telemetry and Telemetry::Period, lizmat++ Nov 5, 2017

TisonKun added some commits Nov 5, 2017

@TisonKun TisonKun changed the title from [WIP] Document Telemetry and Telemetry::Period, lizmat++ to Document Telemetry and Telemetry::Period, lizmat++ Nov 5, 2017

@TisonKun

This comment has been minimized.

Show comment
Hide comment
@TisonKun

TisonKun Nov 5, 2017

Contributor

Locally build ok, will merge it once travis-ci pass

Contributor

TisonKun commented Nov 5, 2017

Locally build ok, will merge it once travis-ci pass

@TisonKun TisonKun merged commit 42d87cf into master Nov 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@TisonKun TisonKun deleted the patch-01 branch Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment