Q:PIR to nqp in HLL::Grammar #45

Closed
wants to merge 11 commits into
from

Conversation

Projects
None yet
3 participants
@kboga
Contributor

kboga commented Jun 5, 2012

Passes all of nqp's tests & rakudo's current passing spectests.

@kboga

This comment has been minimized.

Show comment Hide comment
@kboga

kboga Feb 12, 2013

Contributor

I see you guys are porting over all pir & Q:PIR to nqp so maybe parts of this pull request could be used now?

notes:

  • More recent changes should be hold into account e.g. additions to https://github.com/perl6/nqp/commits/master/src/HLL/Grammar.pm
  • Maybe avoiding using parrot's VTABLE calls to ease porting wouldn't be bad as well.
  • Could be optimized by using natives which didn't exist back then.
  • Some pir::op's could now be translated to more recently added nqp::op's.
  • Cursor's encapsulation shouldn't be broken.
Contributor

kboga commented Feb 12, 2013

I see you guys are porting over all pir & Q:PIR to nqp so maybe parts of this pull request could be used now?

notes:

  • More recent changes should be hold into account e.g. additions to https://github.com/perl6/nqp/commits/master/src/HLL/Grammar.pm
  • Maybe avoiding using parrot's VTABLE calls to ease porting wouldn't be bad as well.
  • Could be optimized by using natives which didn't exist back then.
  • Some pir::op's could now be translated to more recently added nqp::op's.
  • Cursor's encapsulation shouldn't be broken.
@FROGGS

This comment has been minimized.

Show comment Hide comment
@FROGGS

FROGGS Feb 12, 2013

Owner

pmichaud: to whoever is working on nqp #45
pmichaud: + my $opassoc := ~%opO<assoc>;
pmichaud: needs to be my str $opassoc

pmichaud as in, it might even be worth writing things like
pmichaud my %opO := %opOPER<O>
pmichaud to instead be
pmichaud my %opO := nqp::atkey(%opOPER, 'O')
pmichaud depending on how the translation actually takes place.
pmichaud (and to avoid any non-existence checks)

Owner

FROGGS commented Feb 12, 2013

pmichaud: to whoever is working on nqp #45
pmichaud: + my $opassoc := ~%opO<assoc>;
pmichaud: needs to be my str $opassoc

pmichaud as in, it might even be worth writing things like
pmichaud my %opO := %opOPER<O>
pmichaud to instead be
pmichaud my %opO := nqp::atkey(%opOPER, 'O')
pmichaud depending on how the translation actually takes place.
pmichaud (and to avoid any non-existence checks)

@kboga

This comment has been minimized.

Show comment Hide comment
@kboga

kboga Feb 12, 2013

Contributor

I'm sorry but I cannot work on this right now, just wanted to throw out that this pull request exists and that some bits could probably be cherrypicked from it. (although this being an 8 months old pull request).
And yes, the code needs all possible optimizations it could get.

Contributor

kboga commented Feb 12, 2013

I'm sorry but I cannot work on this right now, just wanted to throw out that this pull request exists and that some bits could probably be cherrypicked from it. (although this being an 8 months old pull request).
And yes, the code needs all possible optimizations it could get.

@FROGGS

This comment has been minimized.

Show comment Hide comment
@FROGGS

FROGGS Feb 12, 2013

Owner

Thats not what I meant. I just wanted to put that information there for ppl where that info isnt obvious, like me.

kboga notifications@github.com hat geschrieben:

I'm sorry but I cannot work on this right now, just wanted to throw out that this pull request exists and that some bits could probably be cherrypicked from it. (although it being an 8 months old).
And yes, the code needs all possible optimizations it could get.


Reply to this email directly or view it on GitHub:
#45 (comment)

Owner

FROGGS commented Feb 12, 2013

Thats not what I meant. I just wanted to put that information there for ppl where that info isnt obvious, like me.

kboga notifications@github.com hat geschrieben:

I'm sorry but I cannot work on this right now, just wanted to throw out that this pull request exists and that some bits could probably be cherrypicked from it. (although it being an 8 months old).
And yes, the code needs all possible optimizations it could get.


Reply to this email directly or view it on GitHub:
#45 (comment)

@jnthn

This comment has been minimized.

Show comment Hide comment
@jnthn

jnthn Feb 21, 2013

Owner

All of HLL::Grammar is now in NQP. I took a lot from this pull request, and also updated/optimized it in various places. Thanks! :-)

Owner

jnthn commented Feb 21, 2013

All of HLL::Grammar is now in NQP. I took a lot from this pull request, and also updated/optimized it in various places. Thanks! :-)

@jnthn jnthn closed this Feb 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment