Removed a spurious nqp::clone #97

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@cognominal
Member

No description provided.

@arnsholt
Member
arnsholt commented Oct 8, 2013

The clone isn't entirely spurious. @ns is passed to World.find_sym, which can potentially shift elements off the list (https://github.com/perl6/nqp/blob/master/src/NQP/World.nqp#L618), which means that we're gonna have a bad time later on if we want to use @ns further in that branch of the action.

@arnsholt
Member

@jnthn: What do you think about this? Do we want to keep the clone in case @ns gets used later on, or remove it?

@jnthn
Member
jnthn commented Nov 23, 2014

Yeah, I think I even remember adding the clone to fix a bug, so probably it wants to stay.

@moritz moritz closed this Jan 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment