Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for stubbed class #310

Closed
wants to merge 1 commit into from
Closed

Add test for stubbed class #310

wants to merge 1 commit into from

Conversation

cuonglm
Copy link
Contributor

@cuonglm cuonglm commented Sep 11, 2017

X::Package::Stubbed should not show line number

X::Package::Stubbed should not show line number
@zoffixznet
Copy link
Contributor

zoffixznet commented Sep 14, 2017

I'm going to reject this, as it doesn't make much sense to require a language implementation to never show a line number. For example, showing the location where the stub was declared could be useful. We also tend to avoid testing exact message content, as in the past such tests proved to be too restrictive for no good reason.

If you still'd like to add a test to cover your PR, you could place it into Rakudo's test suite instead. The t/05-messages/01-errors.t file sounds like a fine candidate to place the test into. You can run the test file with make t/05-messages/01-errors.t from rakudo's checkout.

@zoffixznet zoffixznet closed this Sep 14, 2017
@jnthn
Copy link
Contributor

jnthn commented Sep 14, 2017

fwiw, I think we really should show the line where the stub was declared; it'd be much kinder to the user :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants