New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Win32 specific IO::Spec tests so they pass #87

Merged
merged 1 commit into from Dec 12, 2015

Conversation

Projects
None yet
2 participants
@nanis
Contributor

nanis commented Dec 11, 2015

I filed a confused bug report thinking these tests were not passing because of a failure of IO::Spec to delegate to IO::Spec::Win32. Later, I realized that invoking methods on IO::Spec is wrong, and one must use $*SPEC. This chunk of the the test file probably did not get exercised much.

Fix Win32 specific IO::Spec tests so they pass
I filed a confused [bug report][1] thinking these tests were
not passing because of a failure of IO::Spec to delegate to
IO::Spec::Win32. Later, I realized that invoking methods on
IO::Spec is wrong, and one must use $*SPEC. This chunk of the
the test file probably did not get exercised much.
@labster

This comment has been minimized.

Member

labster commented Dec 12, 2015

Looks good to me. Invoking methods on IO::Spec wasn't wrong when I wrote the tests, but definitely became wrong later :)

labster added a commit that referenced this pull request Dec 12, 2015

Merge pull request #87 from nanis/nanis-io-spec-win32-fix
Fix Win32 specific IO::Spec tests so they pass

@labster labster merged commit 61897b1 into perl6:master Dec 12, 2015

@nanis

This comment has been minimized.

Contributor

nanis commented Dec 12, 2015

I figured as much. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment