New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MakeMaker support #1

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@doyleyoung
Contributor

doyleyoung commented Jan 24, 2015

I am participating in the CPAN pull request challenge (http://neilb.org/2014/11/29/pr-challenge-2015.html) and I received your distribution. I noticed you had a .todo with MakeMaker and thought I would add this for my pull request. I didn't see much else I could do to make the module better, but if you have any suggestions I will try to get them done before January 31st. Thanks for making your work available to the world.

Doyle

@perlancar

This comment has been minimized.

Show comment
Hide comment
@perlancar

perlancar Jan 25, 2015

Owner

Hi Doyle,

Thanks for participating in the PR challenge to improve CPAN modules.

Unfortunately I cannot merge your PR. README and Makefile.PL are generated automatically by Dist::Zilla. About the .todo-release-rebuild_with_makemaker file which I put: some time ago I switched to Module::Build, by adding [ModuleBuild] in my dist.ini and removing [MakeMaker] with the goal of making it easier for people without a make tool to build the dist (e.g. on Windows). Later, I found out that Module::Build is being deprecated, so I switched back to MakeMaker by editing dist.ini. Generating Makefile.PL is simply a matter of running 'dzil build' or 'dzil release'.

I just did some cleanup and released a new version of Crypt::Password::Util (0.10). I've added some todo items which you might find worthwhile doing, copy-pasted here from my todo.org:

** WISHLIST [2015-01-25 Min] cryptpwutil: support more crypt types
there are still lots of crypt types supported in Authen::Passphrase which have
not been recognized (i'm usually adding new types on a as-needed basis).

aside from that, there's also sha224 and sha384, used/supported in postgres.

there's bound to be more.

** WISHLIST [2015-01-25 Min] cryptpwutil: (as separate function?) an option to return detailed information about a crypted string
instead of just recognizing its type, we can also parse and return its salt,
header, variant (e.g. in MD5-CRYPT there's an apache variant), or other
information.

** WISHLIST [2015-01-25 Min] cryptpwutil: crypt(): try BCRYPT first
BCRYPT is now the recommended default and should be tried first.

** WISHLIST [2015-01-25 Min] cryptpwutil: improve documentation

  • explain in first paragraph of description that this module is geared towards
    generation and recognition of unix passwords (/etc/shadow), that's why crypt()
    tries several methods but check that each method is supported by your system
    before returning the result.
  • more pointers/links to each crypt type should a user want to find out more.
Owner

perlancar commented Jan 25, 2015

Hi Doyle,

Thanks for participating in the PR challenge to improve CPAN modules.

Unfortunately I cannot merge your PR. README and Makefile.PL are generated automatically by Dist::Zilla. About the .todo-release-rebuild_with_makemaker file which I put: some time ago I switched to Module::Build, by adding [ModuleBuild] in my dist.ini and removing [MakeMaker] with the goal of making it easier for people without a make tool to build the dist (e.g. on Windows). Later, I found out that Module::Build is being deprecated, so I switched back to MakeMaker by editing dist.ini. Generating Makefile.PL is simply a matter of running 'dzil build' or 'dzil release'.

I just did some cleanup and released a new version of Crypt::Password::Util (0.10). I've added some todo items which you might find worthwhile doing, copy-pasted here from my todo.org:

** WISHLIST [2015-01-25 Min] cryptpwutil: support more crypt types
there are still lots of crypt types supported in Authen::Passphrase which have
not been recognized (i'm usually adding new types on a as-needed basis).

aside from that, there's also sha224 and sha384, used/supported in postgres.

there's bound to be more.

** WISHLIST [2015-01-25 Min] cryptpwutil: (as separate function?) an option to return detailed information about a crypted string
instead of just recognizing its type, we can also parse and return its salt,
header, variant (e.g. in MD5-CRYPT there's an apache variant), or other
information.

** WISHLIST [2015-01-25 Min] cryptpwutil: crypt(): try BCRYPT first
BCRYPT is now the recommended default and should be tried first.

** WISHLIST [2015-01-25 Min] cryptpwutil: improve documentation

  • explain in first paragraph of description that this module is geared towards
    generation and recognition of unix passwords (/etc/shadow), that's why crypt()
    tries several methods but check that each method is supported by your system
    before returning the result.
  • more pointers/links to each crypt type should a user want to find out more.

@perlancar perlancar closed this Jan 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment