New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DATE and VERSION keywords after use statements #10

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@paultcochrane

paultcochrane commented Sep 15, 2018

The DATE and VERSION keywords get expanded by Dist::Zilla to our
variables after building the dist. With these variables at the top of
the file, this made code appear before strictures were turned on and
hence caused the author critic tests to fail the strict and warnings
checks. Moving the keywords after the list of dists used by the module
doesn't change the dist's behaviour but allows the author-critic tests
to pass as expected.

If you would like this PR to be changed in any way, please simply let me know and I'll update as appropriate and resubmit it.

Move DATE and VERSION keywords after use statements
The DATE and VERSION keywords get expanded by Dist::Zilla to `our`
variables after building the dist.  With these variables at the top of
the file, this made code appear before strictures were turned on and
hence caused the author critic tests to fail the strict and warnings
checks.  Moving the keywords after the list of dists used by the module
doesn't change the dist's behaviour but allows the author-critic tests
to pass as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment