New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perlcritic warnings #9

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@paultcochrane

paultcochrane commented Sep 15, 2018

perlcritic noticed (at the most gentle setting) various issues with the code. Most of the issues were false alarms and hence I've disabled perlcritic warnings in these cases so that perlcritic is no longer so noisy and so that it can be used to pick up real issues in the future. I've split this PR up into separate commits so that you can cherry pick them as you so wish. If, after having reviewed the code, there's something that you'd like changed, please just let me know and I'll update as necessary and resubmit.

paultcochrane added some commits Sep 15, 2018

Ignore perlcritic warnings on explicit return undef
The code obviously intends to return `undef`, hence we add `## no
critic` annotations in order to keep perlcritic a bit quieter.
Silence perlcritic in __min() function
The `__min()` function uses function prototypes and this is required in
this instance, hence we add an `## no critic` annotation to quieten
perlcritic.
Replace `-t` with `IO::Interactive::is_interactive`
This is recommended, since: "`-t` is fragile and complicated" (see
`Perl::Critic::Policy::InputOutput::ProhibitInteractiveTest` docs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment