Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

CPANRatings HTML markup fixes #49

Merged
merged 13 commits into from Jul 27, 2012

Conversation

Projects
None yet
2 participants
Contributor

dolmen commented Jul 18, 2012

This should improve HTML conformance of the CPAN Ratings site following reports of the W3C Validator.
I have to admit that this is not tested (the 'combust' directory referenced in README.md is empty).

@ghost ghost assigned abh Jul 19, 2012

Contributor

abh commented Jul 27, 2012

@dolmen Thank you! I was on vacation and just got back. If you want to test it, pulling in git submodules (git submodule update --init) should get you what you need.

https://github.com/perlorg/perlweb#clone-the-source

dolmen added some commits Jul 18, 2012

Fix markup in default page template
Make HTML case consistent to all lower case.
Fix opened <P>.
Fix HTML markup case
In the perl-directory template, fix the HTML markup to all lowercase.
CPANRatings About: fix HTML
Fix '&' in URL.
Add 'type' attribute to <script> tags.
CPANRatings form: fix radio: 'selected' => 'checked'
CPANRatings.
Fix the rating form: the radio button 'undef' did not have the right
attribute. Fixed 'selected' to 'checked'.
CPANRatings: fix encoding of '&' in BitCard URLs
'&' is now encoded as '&amp;' in BitCard URLs in <a href='...'>
Contributor

dolmen commented Jul 27, 2012

I've tested the static content (configuring MySQL is too much for now) and rebased my branch on your latest commit. Ready to merge.

Contributor

abh commented Jul 27, 2012

Thanks Olivier!

abh added a commit that referenced this pull request Jul 27, 2012

@abh abh merged commit b5b9e7b into perlorg:master Jul 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment