Check webhook URL properly #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opal-docs canceled.
|
orweis
approved these changes
Jan 12, 2023
The webhook checks OPAL_POLICY_REPO_URL against the URL sent from GitHub. When the user specify a username and a password OPAL_POLICY_REPO_URL, it will fail to match since they don't appear in the webhook payload. Fixing this by removing user & pass before comparing.
roekatz
force-pushed
the
ori/per-3600-incorrect-url-comparison-in-webhook
branch
from
b72f301 to
f557e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webhook checks OPAL_POLICY_REPO_URL against the URL sent from GitHub. When the user specify a username and a password OPAL_POLICY_REPO_URL, it will fail to match since they don't appear in the webhook payload.
Fixing this by removing user & pass before comparing.