Repository navigation
improve error logging, and fix defualt casting - #371
Merged
Merged
Conversation
Signed-off-by: orweis <orweis@gmail.com>
✅ Deploy Preview for opal-docs canceled.
|
roekatz
reviewed
Feb 2, 2023
Contributor
There was a problem hiding this comment.
I have different intuitions about the desired solution here:
- In case the user tries to override a default with a bad value (that fails to parse), OPAL should exit immediately with an error. Running with the default value in that case is certainly not what the user expects.
- Isn't it simpler to just set the correct types for the default values? (rather than basically extending
decouple's behavior from the outside). (e.g. forPOLICY_REPO_WEBHOOK_PARAMS:default=GitWebhookRequestParams({...})instead of just the dict)
Contributor
Author
Sure that's fair; I'll fix accordingly.
You are correct, but only when it comes to pydantic models - you forget other types that are being cast from strings: lists, enums, booleans, numbers, etc. etc. |
Signed-off-by: orweis <orweis@gmail.com>
roekatz
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: orweis orweis@gmail.com