New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether to do relative imports versus from persephone.blah import * #58

Closed
oadams opened this Issue Feb 9, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@oadams
Collaborator

oadams commented Feb 9, 2018

What approach do good project use?

@shuttle1987

This comment has been minimized.

Member

shuttle1987 commented Feb 9, 2018

Once upon a time relative imports were broken somewhat so the suggestion was always to do explicit imports. Now there's a bit more choice since implicit relative imports are not a problem anymore, see: https://mail.python.org/pipermail/python-dev/2010-October/104476.html

Given you are installing the package with setuptools you can use absolute imports everywhere and everything will work because the package name will be on the path. Explicit relative imports (the only type of relative import supported by python3) will also work.

@oadams

This comment has been minimized.

Collaborator

oadams commented Feb 11, 2018

Ok, cool. Let's stick with relative if it's fine.

@oadams oadams closed this Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment