fix: use combine(..., axis="t") in optogenetic demo notebook#11
Merged
hinderling merged 1 commit intoMay 15, 2026
Merged
Conversation
Replace removed RTMSequence + operator with combine() in the two cells that build multi-phase experiments, and update the surrounding markdown.
hinderling
added a commit
to hinderling/faro
that referenced
this pull request
Jun 1, 2026
…ombine fix: use combine(..., axis="t") in optogenetic demo notebook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RTMSequence+operator withcombine(..., axis="t")in the two multi-phase cells ofexperiments/02_demo_sim_optogenetic/demo_sim_optogenetic.ipynb.combineto the import line.The other 11 notebooks that mention
RTMSequencealready usecombine()— this was the last holdout.Test plan
virtual-microscopeextra installed (uv sync --extra virtual-microscope --python 3.12); outputs regenerated.