Added session support. #12

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
4 participants
@kumai

kumai commented Jan 27, 2012

I want to use session in Spark, so I have written some code for session support with Jetty.

@Arnauld

This comment has been minimized.

Show comment
Hide comment
@Arnauld

Arnauld Mar 2, 2012

Would be great to merge it!

Arnauld commented Mar 2, 2012

Would be great to merge it!

@perwendel

This comment has been minimized.

Show comment
Hide comment
@perwendel

perwendel Mar 6, 2012

Owner

HI, I'll have a look at this as soon as possible.
I'm a bit busy being on parental leave until august (takes more time than I thought...)
Br,
Per

Owner

perwendel commented Mar 6, 2012

HI, I'll have a look at this as soon as possible.
I'm a bit busy being on parental leave until august (takes more time than I thought...)
Br,
Per

@perwendel

This comment has been minimized.

Show comment
Hide comment
@perwendel

perwendel Mar 6, 2012

Should throw IllegalArgumentException instead of Nullpointer.

Should throw IllegalArgumentException instead of Nullpointer.

@perwendel

This comment has been minimized.

Show comment
Hide comment
@perwendel

perwendel Mar 6, 2012

I would like this to be removed and the attribute related methods in Session should be used instead. Would make more sense design wise.

I would like this to be removed and the attribute related methods in Session should be used instead. Would make more sense design wise.

@perwendel

This comment has been minimized.

Show comment
Hide comment
@perwendel

perwendel Mar 6, 2012

I would like this to be removed and the attribute related methods in Session should be used instead. Would make more sense design wise.

I would like this to be removed and the attribute related methods in Session should be used instead. Would make more sense design wise.

@perwendel

This comment has been minimized.

Show comment
Hide comment
@perwendel

This comment has been minimized.

Show comment
Hide comment
@perwendel

This comment has been minimized.

Show comment
Hide comment
@perwendel

perwendel Mar 6, 2012

Javadoc on public classes and methods.

Javadoc on public classes and methods.

@perwendel

This comment has been minimized.

Show comment
Hide comment
@perwendel

perwendel Mar 6, 2012

Had a quick lock and added a few comments. Will look more on it when i get a "window"

Had a quick lock and added a few comments. Will look more on it when i get a "window"

@kumai

This comment has been minimized.

Show comment
Hide comment
@kumai

kumai Mar 6, 2012

Thanks for your reply!

I've added some changes as you pointed out, so please check it out when you have time. :-)

kumai commented Mar 6, 2012

Thanks for your reply!

I've added some changes as you pointed out, so please check it out when you have time. :-)

@strigona

This comment has been minimized.

Show comment
Hide comment
@strigona

strigona Apr 24, 2012

Any news on this pull request?

Any news on this pull request?

@perwendel

This comment has been minimized.

Show comment
Hide comment
@perwendel

perwendel May 14, 2012

Owner

Sry, having a hard time finding the spare time to do this. Will try to have a look at this today.

Owner

perwendel commented May 14, 2012

Sry, having a hard time finding the spare time to do this. Will try to have a look at this today.

@strigona

This comment has been minimized.

Show comment
Hide comment
@strigona

strigona May 17, 2012

Thanks for the reply. To be honest, my need for this pull request isn't very significant as I've implemented my own session handling for my application.

Thanks for the reply. To be honest, my need for this pull request isn't very significant as I've implemented my own session handling for my application.

@perwendel

This comment has been minimized.

Show comment
Hide comment
@perwendel

perwendel Nov 22, 2012

Owner

Sorry for taking so long time. I've had attended ALOT of personal business lately which has kept me from working on Spark.

I've added these changes now. I found it easier to just copy and paste since github wouldn't let me merge it automatically! Thanks for a very nice contribution :-).

Owner

perwendel commented Nov 22, 2012

Sorry for taking so long time. I've had attended ALOT of personal business lately which has kept me from working on Spark.

I've added these changes now. I found it easier to just copy and paste since github wouldn't let me merge it automatically! Thanks for a very nice contribution :-).

@perwendel perwendel closed this Nov 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment