Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

dependencies #15

Merged
merged 3 commits into from Mar 23, 2012

Conversation

Projects
None yet
3 participants
Contributor

mikegolod commented Mar 3, 2012

Hi, just spot your nice project today. Little changes in project setup and dependencies to make life of Spark end users easier.

mikegolod added some commits Mar 3, 2012

dependencies cleanup
Unused dependencies removed. End users of Spark don't need
slf4j-simple. They should use their preferrable logging implementation
(log4j, jcl, log back, etc).
Contributor

mikegolod commented Mar 10, 2012

no one interested? :(

kouphax commented Mar 19, 2012

Does this pull request fix the fact that org.apache.commons#commons-io is not valid anymore. Seems it should be commons-io#commons-io. I had to modify the POM in my ivy2 cache to get this to work.

Contributor

mikegolod commented Mar 20, 2012

yes, by removing it completely, cause current codebase doesn't really depend on it

kouphax commented Mar 20, 2012

Then in reply to "no one interested? :("

MEMEMEME

:)

Contributor

mikegolod commented Mar 21, 2012

i wonder if author ever seen this req :(

kouphax commented Mar 21, 2012

One of the other issues sugests he is on paternity leave until August so I suspect he got his hands rather full :)

Owner

perwendel commented Mar 23, 2012

Hi,
As kouphax pointed out I'm on paternity leave but I'll try to have a look at this request as soon I get the time for it.
Best regards,
Per Wendel

Owner

perwendel commented Mar 23, 2012

Ok, a fairly small commmit and it looks good. Thanks for your contribution!

perwendel added a commit that referenced this pull request Mar 23, 2012

@perwendel perwendel merged commit 0e35d02 into perwendel:master Mar 23, 2012

Contributor

mikegolod commented Mar 23, 2012

anytime, welcome

jett pushed a commit to DevFactory/spark that referenced this pull request Jan 1, 2016

Merge pull request #15 in OSCC/perwendel-spark from ccup-testcoverage…
…/UTS-196 to df-unit-test-uts196

* commit '983c9f5371a739f810b5394620d03ac40a026668':
  corrected typo in assertion message, removed unused imports
  added test case to 100% cover Session, added Mockito and Powermock to the POM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment