Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Updated the Request object to enable type capture on the attribute(String) method. #176

Merged
merged 1 commit into from Aug 15, 2015

Conversation

Projects
None yet
2 participants
Contributor

jkwatson commented Jul 19, 2014

Improves the usability of the Request API, now that spark requires java 8.

Owner

perwendel commented Jul 21, 2014

I'm on vacation and I just have my phone so I can't test this. Should the method not change the parameter type to thw generic type. The current signature is strange since it just works for stri gs.

Contributor

jkwatson commented Jul 21, 2014

The parameter is the "key" to the attribute map. Only the return value,
which is the "value" in the attribute map, is being type-captured.

Owner

perwendel commented Jul 21, 2014

deleted due to stupidity...

Owner

perwendel commented Jul 21, 2014

Aah, sorry, now I get it. Mushy brain.

@perwendel perwendel added a commit that referenced this pull request Aug 15, 2015

@perwendel perwendel Merge pull request #176 from jkwatson/enable_type_capture_on_request_…
…attribute

Updated the Request object to enable type capture on the attribute(String) method.
d82881f

@perwendel perwendel merged commit d82881f into perwendel:master Aug 15, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment