-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support miette::IntoDiagnostic for pest::error::Error<R> #582
Comments
|
@bobbbay would you like to tackle this? You mentioned |
|
Yes, I already experimented with this locally. A feature-gated implementation is (in my opinion) the best way to go. The issue is moreso refactoring the internal Error representation so that we can implement miette's I would love to work on this, but I'm currently on vacation and can't always be next to my laptop. If anybody would like to work on this before I get back (end of August), please do. |
|
So what’s the status on this? |
|
The PR is closed and I don't plan on working on this anytime soon. From an implementation standpoint, it's doable. |
It would be nice to be able to more easily use miette to format diagnostics generated by pest errors. Currently, since
pest::error::Error::messageis private, this cannot easily be done by third-party libraries that depend on both pest and miette without re-implementing much of the message formatting logic in pest. It would be helpful if eithermessagewas made public, or if there was a feature-gatedimpl<R> IntoDiagnostic for pest::error::Error<R>to make it easier to include pest errors in miette diagnostics.Thank you! ♥
The text was updated successfully, but these errors were encountered: