Update PesterTests and devcontainer to .NET 8 #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflaten
commented
Apr 3, 2024
CONTRIBUTING.md
Outdated
|
|
||
| [Download Link](https://dotnet.microsoft.com/download/dotnet-core/6.0) | ||
| [Download Link](https://dotnet.microsoft.com/en-us/download/dotnet/8.0) | ||
|
|
||
| ### .Net Framework 4.5 Developer Pack |
There was a problem hiding this comment.
Is the .NET Framework 4.5 Developer Pack necessary now that we use Microsoft.NETFramework.ReferenceAssemblies package? Haven't tested building on Windows in a while.
There was a problem hiding this comment.
Probably not (I have all of them installed so I cannot easily check), but the whole point of that nuget is that you can build .NET Framework even on Linux where it cannot run (without mono).
There was a problem hiding this comment.
Cannot make suggestion that deletes it, please delete it.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Partly addressed in #2432, I will merge the changes once it is in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
.NET 6 is reaching EOL later this year. PR changes:
.NET 8 SDK is already used for building in Azure Pipelines CI.
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.