-
-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PesterTests and devcontainer to .NET 8 #2430
Conversation
CONTRIBUTING.md
Outdated
|
||
[Download Link](https://dotnet.microsoft.com/download/dotnet-core/6.0) | ||
[Download Link](https://dotnet.microsoft.com/en-us/download/dotnet/8.0) | ||
|
||
### .Net Framework 4.5 Developer Pack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the .NET Framework 4.5 Developer Pack necessary now that we use Microsoft.NETFramework.ReferenceAssemblies
package? Haven't tested building on Windows in a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not (I have all of them installed so I cannot easily check), but the whole point of that nuget is that you can build .NET Framework even on Linux where it cannot run (without mono).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot make suggestion that deletes it, please delete it.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Partly addressed in #2432, I will merge the changes once it is in. |
PR Summary
.NET 6 is reaching EOL later this year. PR changes:
.NET 8 SDK is already used for building in Azure Pipelines CI.
PR Checklist
Create Pull Request
to mark it as a draft. PR can be markedReady for review
when it's ready.