[2.x] Implements ArchitectureViolationException to display right collision editor on violation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabio-ivona
commented
Apr 1, 2023
|
|
||
| /** @var array<int, Name> $names */ | ||
| /** @phpstan-ignore-next-line */ | ||
| $names = array_values(array_filter($names, static fn (Name $name): bool => $name->toString() === $target)); |
There was a problem hiding this comment.
here I have a strange phpstan error, can't manage to remove this ignore, any clue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finalizes the work started with nunomaduro/collision#266, nunomaduro/collision@932776f and pestphp/pest#754
it defines a new
ArchitectureViolationExceptionthat implements collision'sRenderableOnCollisionEditorallowing to display the exact code snippet where an architecture violation occurred:https://user-images.githubusercontent.com/8792274/227603858-318d96c0-7220-4c72-ac3a-a3b9491e88d4.png
After this is merged, there are a couple of todos I'd like to implement:
vendor/composer/../../RenderableOnCollisionEditorto not display a custom editor, this will allow to useArchitectureViolationExceptioneverywhere, even where a violation snippet is not needed (eg. in toBeUsedIn() expectations)