From 0a15ae8a04e53a00b8e90564217cfbe21c628e9e Mon Sep 17 00:00:00 2001 From: Vincenzo Petrucci Date: Thu, 16 Nov 2023 15:37:14 +0100 Subject: [PATCH 1/3] fix: Use the percentage to calculate the color. Use the four colors for the success percentage --- src/Printers/Detail.php | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/src/Printers/Detail.php b/src/Printers/Detail.php index f8fafab..2e830a2 100644 --- a/src/Printers/Detail.php +++ b/src/Printers/Detail.php @@ -157,13 +157,23 @@ private function overview(Result $result): void HTML); $successRate = (float) ($metrics['http_req_failed']['values']['fails'] * 100 / $metrics['http_reqs']['values']['count']); - $successRate = sprintf('%4.1f', $successRate); - $successRateColor = $metrics['http_req_failed']['values']['fails'] === $metrics['http_reqs']['values']['count'] - ? 'green' - : 'red'; + $successRateAsString = sprintf('%4.1f', $successRate); + + $successRateColor = 'red'; + switch (true) { + case $successRate > 99: + $successRateColor = 'green'; + break; + case $successRate > 75: + $successRateColor = 'yellow'; + break; + case $successRate > 50: + $successRateColor = 'orange'; + break; + } $this->twoColumnDetail('Success Rate', <<$successRate % + $successRateAsString % HTML); } From fe4eed01c66b2396dbbd37de8c96c2941f3ce2a6 Mon Sep 17 00:00:00 2001 From: Vincenzo Petrucci Date: Thu, 16 Nov 2023 15:43:22 +0100 Subject: [PATCH 2/3] fix: Remove the usage of switch statement --- src/Printers/Detail.php | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/Printers/Detail.php b/src/Printers/Detail.php index 2e830a2..ab72046 100644 --- a/src/Printers/Detail.php +++ b/src/Printers/Detail.php @@ -160,16 +160,12 @@ private function overview(Result $result): void $successRateAsString = sprintf('%4.1f', $successRate); $successRateColor = 'red'; - switch (true) { - case $successRate > 99: - $successRateColor = 'green'; - break; - case $successRate > 75: - $successRateColor = 'yellow'; - break; - case $successRate > 50: - $successRateColor = 'orange'; - break; + if ($successRate > 99) { + $successRateColor = 'green'; + } else if ($successRate > 75) { + $successRateColor = 'yellow'; + } else if ($successRate > 50) { + $successRateColor = 'orange'; } $this->twoColumnDetail('Success Rate', << Date: Thu, 16 Nov 2023 15:46:44 +0100 Subject: [PATCH 3/3] fix: use elseif --- src/Printers/Detail.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Printers/Detail.php b/src/Printers/Detail.php index ab72046..7538a58 100644 --- a/src/Printers/Detail.php +++ b/src/Printers/Detail.php @@ -162,9 +162,9 @@ private function overview(Result $result): void $successRateColor = 'red'; if ($successRate > 99) { $successRateColor = 'green'; - } else if ($successRate > 75) { + } elseif ($successRate > 75) { $successRateColor = 'yellow'; - } else if ($successRate > 50) { + } elseif ($successRate > 50) { $successRateColor = 'orange'; }