[2.x] feat(parallel): Adds support for plugins to filter parallel arguments #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeraymonddowning
force-pushed
the
2.x_parallel_args
branch
from
88eda71
to
71730d6
Compare
nunomaduro
force-pushed
the
2.x_parallel_args
branch
from
71730d6
to
7f9d044
Compare
|
@lukeraymonddowning, I still don't think that this resolves the issue... 🤔 Unless I'm implementing the contract wrongly, it seems to have stripped the |
nunomaduro
requested changes
Mar 21, 2023
lukeraymonddowning
force-pushed
the
2.x_parallel_args
branch
from
169e21b
to
4c769fa
Compare
owenvoke
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically,
CallsHandlesArgumentsis not executed fully in parallel (and rightly so). However, this means that plugins have no way of altering arguments and thus supporting parallel execution.This PR adds a new action and contract that allows plugins to alter parallel arguments before parallel execution.