Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove dataset name from DatasetArgsCountMismatch #736

Merged
merged 1 commit into from Mar 24, 2023

Conversation

fabio-ivona
Copy link
Collaborator

@fabio-ivona fabio-ivona commented Mar 24, 2023

@nunomaduro I feel that the dataset argument count mismatch error message may be too long for not-named complex datasets

Maybe we could remove it, as the dataset should be stated at the top of the failure message

before:

image

after:

image

@fabio-ivona fabio-ivona changed the title remove dataset name from DatasetArgsCountMismatch [chore] Remove dataset name from DatasetArgsCountMismatch Mar 24, 2023
@nunomaduro nunomaduro merged commit 50a96dc into pestphp:2.x Mar 24, 2023
14 checks passed
@fabio-ivona fabio-ivona deleted the fix-dataset-mismatch-message branch March 24, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants