Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in spelling of "dataset" #739

Merged

Conversation

dansysanalyst
Copy link
Collaborator

Q A
Bug fix? no
New feature? no
Fixed tickets

This PR proposes to alter "data set" to "dataset" in test descriptions.

It seems the most often used spelling is "dataset".

However, in the tests description and in an Exception, it is spelled "data set".

CleanShot 2023-03-24 at 16 08 54@2x

Below, we have both cases in one sentence.

CleanShot 2023-03-24 at 16 14 59@2x

Consistent usage

Documentation: https://pestphp.com/docs/datasets

Docblock:

    /**
     * Ensures dataset items count matches underlying test case required parameters
     * ...
     */

@nunomaduro nunomaduro merged commit 5df46d0 into pestphp:2.x Mar 24, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants