Fix parallel execution of test class that extends another class with same name #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test class that extends another class with the same name but in different directory is not loaded in parallel execution. The
TestSuiteLoadergets confused and loads the parent class instead.The confusion comes from this line:
if ($class->isAbstract() || ($class->getFileName() !== $suiteClassFile)) {It's because the getFileName() returns the absolute path while the suiteClassFile contains the relative path. This does not seem to be the case for normal execution.
I have added a test that reproduces the issue along with the fix.