[2.x] fix: tests in Helpers directory are not executed #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeraymonddowning
changed the title
nunomaduro
requested changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to have tests in the "Helpers" directory.
The reason the tests are not executed is because all PHP files in the "Helpers" directory are loaded before building the test suite.
In this case they have a different backtrace which does not contain "overrides/Runner/TestSuiteLoader.php". Therefore I have extended the "Backtrace" class with an additional path to check for: "src/Bootstrappers/BootFiles.php"
Additionally I've added two new tests:
it executes tests in the Helpers directoryin "tests/Helpers/TestInHelpers.php" to ensure tests in the "Helpers" directory are executed.it can use helpers from helpers directoryin "tests/Features/Helpers.php" to ensure the helpers still work (before there was no test covering this feature)