Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to filter out noise from trace open telemetry #49

Closed
TerryDieckmann opened this issue Mar 11, 2022 · 8 comments
Closed

Unable to filter out noise from trace open telemetry #49

TerryDieckmann opened this issue Mar 11, 2022 · 8 comments
Labels
tracing 🔬 Tracing issues
Milestone

Comments

@TerryDieckmann
Copy link

TerryDieckmann commented Mar 11, 2022

I am currently investigating how we can best use OTel and Phobos in our software solution. During the implementation I can't really figure out how to filter out the messages below without adding an endless list of separate message filters.

The trace-actor-lifecycle option is disabled, but there are still plenty of internal akka (unnecessary) messages.

image

Using .NET 6, Akka.NET Cluster, Open Telemetry and Phobos.

@TerryDieckmann TerryDieckmann changed the title Unable to filter out noise from trace open telementry Unable to filter out noise from trace open telemetry Mar 11, 2022
@Aaronontheweb
Copy link
Member

Thanks Terry - we'll take a look at this.

@Aaronontheweb Aaronontheweb added the tracing 🔬 Tracing issues label Mar 11, 2022
@Aaronontheweb Aaronontheweb added this to the Phobos 2.0 milestone Mar 11, 2022
@TerryDieckmann
Copy link
Author

Thanks Aaron,
It might be good to know that I use Phobos.Actor.Cluster 2.0.0-beta3. I've tried filtering out the bulk of (to me) unnecessary messages, but when I do that, half of the trace is no longer included because it is a child of akka.msg.recv GetShardHome.

@Aaronontheweb
Copy link
Member

We have another issue related to trace filtering on Phobos 1.4 with #46 - so let's just say that this has been clearly identified as a "user experience" problem across all use cases ;)

We learned some lessons on how to handle filtering more robustly when we implemented type filters for security purposes inside Hyperion akkadotnet/akka.net#5329 (comment)

I'll work on improving the upfront filtering and also add an example for using an OTel Processor on the back-end.

@Aaronontheweb
Copy link
Member

Wrote up our plans for addressing this on a related issue here: #46 (comment) - would love your feedback on it @TerryDieckmann

@Aaronontheweb
Copy link
Member

Hi @TerryDieckmann - we have pushed new Phobos 2.0 binaries that have an API change that should nip this problem in the bud.

Please see the release notes here and follow the configuration instructions - I think this should help quite a bit: https://phobos.petabridge.com/articles/releases/RELEASE_NOTES.html#200-beta4httpssdkbincompublisherpetabridgeproductphobospackagesphobosactorversions200-beta4-and-150-beta1httpssdkbincompublisherpetabridgeproductphobospackagesphobosactorversions150-beta1-march-17th-2022

@TerryDieckmann
Copy link
Author

I will have a look, thanks!

@TerryDieckmann
Copy link
Author

I've implemented my own tracer filter and it works great! Traces are complete and not full of messages we don't really need. Thank you, Aaron!

@Aaronontheweb
Copy link
Member

Glad to hear it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracing 🔬 Tracing issues
Projects
None yet
Development

No branches or pull requests

2 participants