Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

CMake support #131

Closed
mikemcquaid opened this Issue · 12 comments

3 participants

@mikemcquaid

Ack should support reading CMakeLists.txt files.

Would a patch for this be accepted?

@petdance
Owner

Would it be --cmake or lumped in with --make? I think the latter would be better.

@mikemcquaid

I'd say it should be --cmake as it is it's own language and when using a CMake buildsystem I'd want to disable --make and enable --cmake as the Makefiles are generated and therefore no longer interesting to me.

@nhooey

I'm guessing petdance will say that this won't be implemented until Ack 2.0.

@mikemcquaid

It should be a very easy fix, just searching based on filenames. It would be good to get it in before 2.0, if possible.

@mikemcquaid

Any more thoughts on this? Just adding the search to .txt files works in the meantime but it would be great to be able to search only files named CMakeLists.txt. I tried to do it myself but my perl-foo isn't strong. I could maybe manage with some pointers.

@nhooey

I'm considering forking ack to add many of the patches that petdance says he won't bother with until version 2.0. Stay tuned, and I'll notify you if I do this. Then we can add your feature.

@petdance
Owner

How about you talk to me/us on the mailing list before going down the fork road, Neil?

@nhooey

I had the impression that you weren't going to implement any new features until Ack 2.0.

I put in a pull request, complete with tests, that nobody has looked at, and there's a patch for files without extensions.

Could you have a look at those?

@petdance
Owner

Post to the list and let's see what the accumulated readership thinks. When we're talking about changing stuff as potentially disruptive as file selection, I want to get public eyeballs on it.

@petdance
Owner

Also, your link to that pull request is broken.

@nhooey

The link is fixed now.

I'll post to the mailing list.

@petdance
Owner

cmake has been added to ack 2.

@petdance petdance closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.