Re: ack may ignore files with multi-byte encodings #129

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

anno5 commented Sep 13, 2010

I think my one-line change to Basic.pm solves the problem I pointed out. It does for me (obviously) and doesn't hurt the existing tests.

I haven't been able to make up a specific test for the rejection of multibyte-encoded files with the given testing framework. There seem to be additional encoding problems that make it hard to use run_ack() for that. So I'm just sending the fix.

Anno

@anno5 anno5 Changed behavior of needs_line_scan() to accept multi-byte encodings
The change in ack reflects the change in Basic.pm
f645de3

hoelzro referenced this pull request in petdance/ack2 Aug 28, 2013

Closed

Re: ack may ignore files with multi-byte encodings #350

Collaborator

hoelzro commented Aug 28, 2013

Migrated to ack2 queue.

hoelzro closed this Aug 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment