Add test for --ignore-dir=FILTER:FILTERARGS #169

Open
hoelzro opened this Issue Dec 15, 2012 · 4 comments

Projects

None yet

3 participants

@hoelzro
Collaborator
hoelzro commented Dec 15, 2012

Currently, we only test the --ignore-dir=DIRNAME form of the --ignore-dir option. Tests for the new syntax must be added. Since non-is filters don't work at the moment, these tests should be implemented but marked as TODO.

@andrewblack
Contributor

Which other filters might be supported in future. My guess is

  • match - yes
  • firstlinematch - no
  • ext - no

Are there any other possible filters

@hoelzro
Collaborator
hoelzro commented Jan 11, 2013

@andrewblack Those are the only filters built into ack right now, so those are the only ones that need testing!

@hoelzro
Collaborator
hoelzro commented Nov 3, 2014

There are some new tests for this, but it could probably use some improvement.

@hoelzro
Collaborator
hoelzro commented Nov 3, 2014

One test that needs adding is making sure --ignore-dir=foo --ignore-dir=bar --noignore-dir=bar behaves correctly when foo/bar is encountered (it should search files under foo/bar)

@petdance petdance added ignores and removed low-hanging-fruit labels Mar 17, 2017
@petdance petdance removed this from the Later milestone Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment