-g -i should search filenames case-insensitive #49

Closed
petdance opened this Issue Apr 27, 2012 · 6 comments

Comments

Projects
None yet
2 participants
Owner

petdance commented Apr 27, 2012

$ ack -g smtp
smtptunnel
$ ack -g SMTP
$ ack -g SMTP -i

This last case with -g -i should find smtptunnel as a filename.

Collaborator

hoelzro commented Apr 29, 2012

@petdance I'm looking through the test case for -g; how does this apply to -G?

Owner

petdance commented Apr 29, 2012

Oh, man, now I remember about this. Does the -i apply to the -g or to the main regex? Bleh.

I think we might have to get rid of -G

Collaborator

hoelzro commented May 1, 2012

The way I see it, we have several options:

  1. Get rid of -G.
  2. Cancel this idea.
  3. Make -i apply to the file regex in -g (as in this idea), and make -i apply to the file contents regex when using -G.
  4. Add a new flag, -I or something, to differentiate between the two.

3 strikes me as inconsistent, and 4 strikes me as overly complicated. 2 favors backwards compatibility, and 1 might make some people angry. I'll ask ack-users.

Collaborator

hoelzro commented May 2, 2012

Owner

petdance commented May 3, 2012

I'm thinking -I is the way to go.

Owner

petdance commented May 13, 2012

-G is gone. fb45c46

petdance closed this May 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment