Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

-g -i should search filenames case-insensitive #49

Closed
petdance opened this Issue · 6 comments

2 participants

@petdance
Owner
$ ack -g smtp
smtptunnel
$ ack -g SMTP
$ ack -g SMTP -i

This last case with -g -i should find smtptunnel as a filename.

@hoelzro
Collaborator

@petdance I'm looking through the test case for -g; how does this apply to -G?

@petdance
Owner

Oh, man, now I remember about this. Does the -i apply to the -g or to the main regex? Bleh.

I think we might have to get rid of -G

@hoelzro
Collaborator

The way I see it, we have several options:

  1. Get rid of -G.
  2. Cancel this idea.
  3. Make -i apply to the file regex in -g (as in this idea), and make -i apply to the file contents regex when using -G.
  4. Add a new flag, -I or something, to differentiate between the two.

3 strikes me as inconsistent, and 4 strikes me as overly complicated. 2 favors backwards compatibility, and 1 might make some people angry. I'll ask ack-users.

@hoelzro
Collaborator
@petdance
Owner

I'm thinking -I is the way to go.

@petdance
Owner

-G is gone. fb45c46

@petdance petdance closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.