New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perlcritic fixes #43

Closed
wants to merge 2 commits into
base: dev
from

Conversation

Projects
None yet
2 participants
@bk

bk commented Jun 18, 2015

Two tiny changes in order to placate perlcritic:

  • Remove explicit disabling of RequireRcsKeywords policy in perlcriticrc, since it is deprecated anyway now.
  • return rather than return undef in _normalize_value: see PBP, p. 199.
@petdance

This comment has been minimized.

Show comment
Hide comment
@petdance

petdance Jun 18, 2015

Owner

Thanks for the cleanups.

The return undef is specifically there to return an undef value. There's no improvement in removing the explicit undef.

Owner

petdance commented Jun 18, 2015

Thanks for the cleanups.

The return undef is specifically there to return an undef value. There's no improvement in removing the explicit undef.

@petdance

This comment has been minimized.

Show comment
Hide comment
@petdance

petdance Dec 7, 2016

Owner

The perlcriticrc change has been manually applied at e09794b. Thanks.

Owner

petdance commented Dec 7, 2016

The perlcriticrc change has been manually applied at e09794b. Thanks.

@petdance petdance closed this Dec 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment