Skip to content

Andy Lester
petdance

Organizations

@Perl-Critic
@petdance
Create policy for finding variables that have almost the same name in the same scope.
petdance commented on issue petdance/ack2#339
@petdance

It's your ticket, @kojustin. Are you satisfied with the fix?

petdance commented on issue vim-perl/vim-perl#211
@petdance

Please be sure to note it in the change log.

@petdance
@petdance
@petdance
  • @petdance 06ebfd2
    Importing Test::Memory::Cycle 1.04, with minor tweaks to the README
@petdance
Create policy for detecting mix of returning scalars and empty returns
petdance commented on pull request petdance/ack2#591
@petdance

Sorry, I didn't mean you needed to do it. It was a reminder for me and @hoelzro.

petdance commented on pull request petdance/ack2#591
@petdance

I'm OK with adding these, but there's more to do than just this pull request. We need to add a note to the change log and add Austin to the ACKnowl…

petdance commented on pull request petdance/ack2#591
@petdance

Thanks for the pull request. Now please post this to the ack-users mailing list, as discussed in the manual and FAQ. Thanks.

petdance commented on pull request vim-perl/vim-perl#207
@petdance

I think it would be fine to host it as vim-perl/whatever as well. It would give them the visibility they deserve. (I really like the use of the wor…

petdance commented on pull request vim-perl/vim-perl#207
@petdance

Aha, I didn't know there was backstory to this. I think that explains some of the confusion for @jhthorsen, that we were looking at this from diffe…

petdance commented on pull request vim-perl/vim-perl#207
@petdance

I'm sorry, @jhthorsen, I'll try to explain further. My concerns are not about the quality of the code today, but about the ongoing maintenance of t…

petdance commented on pull request vim-perl/vim-perl#207
@petdance

Please go back and read my comments where I discuss some of the concerns I have. You'll see I say nothing about quality of code, and only question …

petdance commented on pull request vim-perl/vim-perl#207
@petdance

Letting me know that it require improvements None of this is about the quality of the code at all. I haven't even looked at the code other than …

petdance commented on pull request vim-perl/vim-perl#207
@petdance

Please mention me if someone report a bug on it and I will have a look. This is another example of why I'm thinking that it's not useful to put i…

petdance commented on pull request vim-perl/vim-perl#207
@petdance

If we're not supporting it, then what's the value of contrib/ at all? If it's just a drawer of stuff that we accumulate from other sources, then wh…

petdance commented on pull request vim-perl/vim-perl#207
@petdance

Is this something that's appropriate to be putting in vim-perl? I understand it's contrib/ but what are the social implications of including it? Ar…

@petdance

The writer in fact meant /^(?:foo|bar)$/ There may be cases where that's true, but I've never seen a case where the \n distinction was relevant. …

@petdance
Suggested policy: Flag /^dog|cat$/
petdance commented on pull request petdance/ack2#558
@petdance

@epa: We need to stick to facts and not use words like "correct" or "wrong", because that's an opinion, and everyone has an opinion on things but t…

petdance commented on pull request petdance/ack2#558
@petdance

How does grep handle this? If you grep -w mu., what behavior do you get?

petdance commented on issue petdance/ack2#589
@petdance

Similarly, this attempt to find any lines with all whitespace returns every empty line. ack '^\s+$' foo

petdance commented on issue petdance/ack2#588
@petdance

Add a mention of -g to the FAQ question about -f.

petdance commented on issue petdance/ack2#588
@petdance

Thanks for this. Other thoughts: Emphasize that -g is a grep version of -f, and make sure people understand what -f is. The overarching thing that …

Something went wrong with that request. Please try again.