Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument add-pattern-array #1005

Merged
merged 5 commits into from Dec 13, 2021

Conversation

avdeev-dima-tutu
Copy link
Contributor

@avdeev-dima-tutu avdeev-dima-tutu commented Dec 8, 2021

Add argument add-pattern-array to commit file with patterns. All other files will be cleaned.

Usage:

      - name: Create Pull Request
        uses: tutu-ru-mobile/create-pull-request@tutu  # Off course here will changed to peter-evans/...
        with:
          add-pattern-array: |
            **.txt
            **some/dirs**.png
          token: ${{ secrets.GITHUB_TOKEN }}

Working sample:
https://github.com/avdim/test_pull_request_creation/blob/main/.github/workflows/blank.yml

Also need to fix README.md, because in version @V3 this argument not exists. I put @main branch in README.md

What do you think about this PR ?

@peter-evans
Copy link
Owner

Hi @avdeev-dima-tutu

So far I've tried to avoid the need for this feature because I didn't want to complicate the action further, and there are other ways to handle this such as creating your own commits. However, your implementation using git add is simple and clean, so I'm considering adding this feature.

I'm going to merge this PR to a dev branch so that I can fix the tests and make some minor updates. If/when I'm satisfied the feature will then be merged to main with your commits.

Thank you for this contribution!

@peter-evans peter-evans changed the base branch from main to dev December 13, 2021 03:38
@peter-evans peter-evans merged commit 59720db into peter-evans:dev Dec 13, 2021
3 of 4 checks passed
@peter-evans
Copy link
Owner

I've released the feature in v3.12.0 / v3. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants