Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GA quote/ref in concepts-guidelines.md #1169

Merged
merged 2 commits into from Apr 13, 2022

Conversation

dannyroberts
Copy link
Contributor

Stumbled upon this when reading the documentation. The current quote and reference link appear to be out of date.

The current quote and reference link appear to be out of date
Copy link
Owner

@peter-evans peter-evans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this!

I just have one suggestion to change the link, but otherwise looks good to me. 👍


[GitHub Actions: Events that trigger workflows](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token)

[GitHub Actions: Automatic token authentication](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be a slightly more relevant link. It's the same paragraph, but just a different page that is more focused around triggering workflows from runs.

Suggested change
[GitHub Actions: Automatic token authentication](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow)
[GitHub Actions: Automatic token authentication](https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow)

@dannyroberts
Copy link
Contributor Author

I see, the two links (the one I used and the one you suggested) have similar text. I updated it to reference the link you suggested and also quote the exact text from that link (which itself contains a link that redirects to the link I had found). Does that look right?

@peter-evans peter-evans merged commit 97872c4 into peter-evans:main Apr 13, 2022
@peter-evans
Copy link
Owner

Thanks!

@dannyroberts dannyroberts deleted the patch-1 branch April 14, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants