Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no_proxy environment variable #1205

Merged
merged 1 commit into from Aug 17, 2022
Merged

Conversation

tillganster
Copy link
Contributor

In our case we have self hosted runners which are managed by our enterprise. All the proxy envvars are set in the runners itself.
And we would need the proxy if we would go to github.com but not if we use this action to create a PR in our self hosted github enterprise.

This change will check the environment variable no_proxy and will only use proxy agent if the requested url is not part of this variable. Currently this only works without wildcards in the domains which are part of no_proxy.

Let me know if something like this is out of scope or if there should be further changes.

@peter-evans
Copy link
Owner

peter-evans commented Aug 17, 2022

/test repository=tillganster/create-pull-request ref=main build=true

Command run output

@peter-evans
Copy link
Owner

Hi @tillganster

Thank you for contributing!

This looks good to me. Merging!

@peter-evans peter-evans merged commit 8557470 into peter-evans:main Aug 17, 2022
4 checks passed
@peter-evans
Copy link
Owner

Released as v4.1.0 / v4

@peter-evans
Copy link
Owner

@tillganster Just to let you know that I've switched out the proxy implementation in the latest release (v4.2.0). It should handle no_proxy correctly. Let me know if you have any problems.

@peter-evans
Copy link
Owner

@tillganster Just to let you know that I'm planning to revise the proxy implementation again. Please see here for further details.

@tillganster
Copy link
Contributor Author

@peter-evans Thanks for the information. Let me know if I can help or contribute in this context!

@peter-evans
Copy link
Owner

If you are able to test the v5-beta version of the action and check that no_proxy works as expected, that would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants