Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support github server url for pushing to fork #1315

Merged
merged 1 commit into from Nov 22, 2022

Conversation

MildC
Copy link
Contributor

@MildC MildC commented Nov 15, 2022

This commit added the support for alternative github server but the server url is still hard coded in getRemoteUrl function. This breaks the pushing to fork workflow

@peter-evans
Copy link
Owner

@MildC Thank you for this contribution! Your fix looks good. I'm just going to merge it to a feature branch in this repository to fix the build before merging to main.

Have you been able to test your feature branch and confirm that it works? It might be difficult for me to do that because I don't run self-hosted GitHub.

@peter-evans peter-evans changed the base branch from main to serverurl November 22, 2022 02:06
@peter-evans peter-evans merged commit 7e67080 into peter-evans:serverurl Nov 22, 2022
3 of 4 checks passed
@MildC
Copy link
Contributor Author

MildC commented Nov 22, 2022

@peter-evans Thanks for merging! I tested the new code on the feature branch and it can create the PR properly!

@peter-evans
Copy link
Owner

@MildC Great. Thank you for confirming!

peter-evans added a commit that referenced this pull request Nov 24, 2022
* feat: support github server url for pushing to fork (#1315)

Co-authored-by: Kevin Zhu <kevin.zhu@sap.com>

* fix: code formatting

* test: fix tests for getRemoteUrl

Co-authored-by: MildC <kevin.xizhu@gmail.com>
Co-authored-by: Kevin Zhu <kevin.zhu@sap.com>
@peter-evans
Copy link
Owner

Released as v4.2.2 / v4.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants